Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pceplib: fix compilation error #15211

Merged

Conversation

pguibert6WIND
Copy link
Member

The following compilation error happens, with pcep test files.

In file included from pceplib/test/pcep_utils_counters_test.c:31:
pceplib/test/pcep_utils_counters_test.c: In function 'test_create_subgroup_counter':
pceplib/test/pcep_utils_counters_test.c:127:25: error: too few arguments to function 'create_subgroup_counter'
127 | CU_ASSERT_FALSE(create_subgroup_counter(subgroup, counter_id + 1,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from pceplib/test/pcep_utils_counters_test.c:33:
./pceplib/pcep_utils_counters.h:163:6: note: declared here
163 | bool create_subgroup_counter(struct counters_subgroup *subgroup,
| ^~~~~~~~~~~~~~~~~~~~~~~
Makefile:10948: recipe for target 'pceplib/test/pceplib_test_pcep_utils_tests-pcep_utils_counters_test.o' failed
make[3]: *** [pceplib/test/pceplib_test_pcep_utils_tests-pcep_utils_counters_test.o] Error 1
make[3]: *** Waiting for unfinished jobs....

There is a missing parameter.

Fixes: 09047d2 ("pceplib: add json string option to subgroup counter")

The following compilation error happens, with pcep test files.

> In file included from pceplib/test/pcep_utils_counters_test.c:31:
> pceplib/test/pcep_utils_counters_test.c: In function 'test_create_subgroup_counter':
> pceplib/test/pcep_utils_counters_test.c:127:25: error: too few arguments to function 'create_subgroup_counter'
>   127 |         CU_ASSERT_FALSE(create_subgroup_counter(subgroup, counter_id + 1,
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~
> In file included from pceplib/test/pcep_utils_counters_test.c:33:
> ./pceplib/pcep_utils_counters.h:163:6: note: declared here
>   163 | bool create_subgroup_counter(struct counters_subgroup *subgroup,
>       |      ^~~~~~~~~~~~~~~~~~~~~~~
> Makefile:10948: recipe for target 'pceplib/test/pceplib_test_pcep_utils_tests-pcep_utils_counters_test.o' failed
> make[3]: *** [pceplib/test/pceplib_test_pcep_utils_tests-pcep_utils_counters_test.o] Error 1
> make[3]: *** Waiting for unfinished jobs....

There is a missing parameter.

Fixes: 09047d2 ("pceplib: add json string option to subgroup counter")

Signed-off-by: Philippe Guibert <[email protected]>
@frrbot frrbot bot added the bugfix label Jan 24, 2024
@donaldsharp donaldsharp merged commit e3e4232 into FRRouting:master Jan 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants